[PATCH] D31860: Add more examples to clang tidy checkers

Sylvestre Ledru via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 11 09:41:19 PDT 2017


sylvestre.ledru added inline comments.


================
Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:15
+
+  void a(int  /*i*/) {}
+
----------------
alexfh wrote:
> nit: two spaces before the comment.
I believe it is the case ? 
I stole this from the unit test //test/clang-tidy/misc-unused-parameters.c//


================
Comment at: docs/clang-tidy/checks/readability-uniqueptr-delete-release.rst:11
+
+  delete P.release();
+
----------------
alexfh wrote:
> nit: I'd add a bit more context, namely the definition of P.
done in r299961


https://reviews.llvm.org/D31860





More information about the cfe-commits mailing list