[PATCH] D31853: [clangd] Implement item kind for completion results

Stanislav Ionascu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 10 12:57:10 PDT 2017

stanionascu added a comment.

In https://reviews.llvm.org/D31853#722219, @krasimir wrote:

> Looks good! However it would be easier for reviewers if you could please use arc: http://llvm.org/docs/Phabricator.html#id2
>  This makes it easy since I only have to do `arc patch D31853` in order to update my client source tree with your changes.
>  Could you please create a review like that?

I did use arc diff to upload this patch, from my git clone as described in http://llvm.org/docs/GettingStarted.html#developers-work-with-git-svn
I've recreated the clone now and the `arc patch D31853`  seems to work for both git+svn/svn clones.
Sorry if my setup was causing issues.


More information about the cfe-commits mailing list