[PATCH] D31840: [analyzer] Fix crash on access to property

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 10 11:19:18 PDT 2017


NoQ added a comment.

This defensive check looks reasonable regardless of how well we model unions (we don't). Thanks for the patch!



================
Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:706
+      }
       Values.push_back(IvarLVal);
       return;
----------------
I believe there's not much to `push_back` here when we don't have the region. So this can go under the `if(){}` as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D31840





More information about the cfe-commits mailing list