[PATCH] D31771: [AMDGPU] Temporarily change constant address space from 4 to 2 for the new address space mapping

Tony Tye via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 6 10:03:27 PDT 2017


t-tye added a comment.

LGTM



================
Comment at: lib/Basic/Targets.cpp:2083
         Local     = 3;
-        Constant  = 4;
+        Constant  = 2;
         Private   = 5;
----------------
t-tye wrote:
> Since Constant is now the same regardless of the GIZ setting, should it be moved to be a literal constant like the other values that do not change?
Disregard comment as was thinking of the LLVM way address spaces were being handled.


https://reviews.llvm.org/D31771





More information about the cfe-commits mailing list