[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 6 07:50:17 PDT 2017


Hahnfeld added inline comments.


================
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:430
+bool tools::addOpenMPRuntime(ArgStringList &CmdArgs, const ToolChain &TC,
+                             const ArgList &Args, const JobAction &JA,
+                             bool GompNeedsRT) {
----------------
ABataev wrote:
> Do you really need to pass a reference to `JobAction` here or it is enough to pass a bool value for `JA.isHostOffloading()`?
Good idea, this even allows this change to become fully NFC


https://reviews.llvm.org/D30087





More information about the cfe-commits mailing list