[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

Richard Bradfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 6 04:59:44 PDT 2017


bradfier added inline comments.


================
Comment at: include/clang/Basic/LangOptions.def:95
 LANGOPT(ObjC2             , 1, 0, "Objective-C 2")
+LANGOPT(Java              , 1, 0, "Java")
 BENIGN_LANGOPT(ObjCDefaultSynthProperties , 1, 0,
----------------
arphaman wrote:
> I don't think we should have a `Java` lang option, since Clang is not actually a Java frontend. Maybe another option like `LogicalShiftOperators` will work better?
That seems reasonable. C and C++ have `>>>` or `<<<` operators as part of CUDA extensions though, so maybe the full `LogicalShiftAssignOperators` is more precise?


Repository:
  rL LLVM

https://reviews.llvm.org/D31652





More information about the cfe-commits mailing list