[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 6 02:59:43 PDT 2017


ioeric added a comment.

Still LGTM. Please run `ninja check-clang` and fix the warning. I'll land this patch for you afterwards.



================
Comment at: lib/Tooling/RefactoringCallbacks.cpp:222
+    }
+    default:
+      llvm_unreachable("Element.Type not recognized");
----------------
```
ninja check-clang
RefactoringCallbacks.cpp:222:5: warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]
```
Please remove the `default`.



https://reviews.llvm.org/D29621





More information about the cfe-commits mailing list