[PATCH] D30009: Add support for '#pragma clang attribute'

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: lib/Sema/SemaAttr.cpp:578
+    return;
+  Diag(PragmaAttributeStack.back().Loc, diag::warn_pragm_attribute_no_pop_eof);
+}
----------------
arphaman wrote:
> aaron.ballman wrote:
> > Perhaps adding a FixIt here would be a kindness?
> Where would the fix-it point to? I think only the user will know the location at which they meant to insert `#pragma clang attribute pop`.
Given that it's a warning rather than an error, and our recovery mechanism is to effectively pop the pragma at the end of the TU, I was thinking it could be added at the end of the TU. However, you are correct that it's probably not where the programmer needs it, so a FixIt likely isn't appropriate. Does that suggest the warning should be an error instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D30009