[PATCH] D25596: alpha.core.Conversion - Fix false positive for 'U32 += S16; ' expression, that is not unsafe

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

> There are several undetected "TODO: loss of precision" right now in the tests that I would like to fix.

I think it's a good idea to have `// no-warning` comments as well when testing for lack of false positives.

I've a feeling that the original false positive that you've been fixing initially has disappeared from the final tests (we've got stuff with unsigned long += int, but large types behave quite differently when it comes to integral promotion). If i'm wrong, please commit :)


Repository:
  rL LLVM

https://reviews.llvm.org/D25596