[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 3 18:11:21 PDT 2017


EricWF added a comment.

This started making the libc++ bots fail, and I'm not convinced the case is reasonable to warn on. That case is:

  struct path {
    using value_type = char;
    struct iterator { 
      using value_type = path;
    };
  };

Obviously both typedefs are necessary, and according to the standard they are both required to have the same name. I would prefer not to have to `#pragma` disable this diagnostic within `<filesystem>`


Repository:
  rL LLVM

https://reviews.llvm.org/D31235





More information about the cfe-commits mailing list