[PATCH] D31513: [Sema] Add __is_aggregate type-trait and implement LWG 2015

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 3 17:48:02 PDT 2017


EricWF added inline comments.


================
Comment at: lib/Sema/SemaExprCXX.cpp:4089
+    // See LWG 2015
+    QualType ElTy = S.Context.getBaseElementType(ArgTy);
     if (ElTy->isVoidType())
----------------
aaron.ballman wrote:
> If I understand properly, this change is required by LWG 2015 for existing type traits *and* is needed for is_aggregate()? If so, it probably should be a separate patch doing just LWG 2015 (and tests) and a second one for is_aggregate().
Ack. 


https://reviews.llvm.org/D31513





More information about the cfe-commits mailing list