[PATCH] D31447: [Driver] Add option to print the resource directory

Chris Bieneman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 3 15:31:36 PDT 2017


beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

One minor nitpick on the test case, but otherwise this looks fine to me.



================
Comment at: test/Driver/immediate-options.c:19
+// RUN: %clang -print-resource-dir | FileCheck %s -check-prefix=PRINT-RESOURCE-DIR
+// PRINT-RESOURCE-DIR: {{.*}}
+
----------------
This should probably be matching `+` instead of `*`. As written this would succeed even if the output was empty.


https://reviews.llvm.org/D31447





More information about the cfe-commits mailing list