[PATCH] D31491: [XRay][clang] Fix the -fxray-instruction-threshold flag processing

[Dean Michael Berris via Phabricator via cfe-commits]

dberris added inline comments.


================
Comment at: test/CodeGen/xray-instruction-threshold.cpp:11
+
+// CHECK-DAG: define i32 @_Z3foov() #[[THRESHOLD:[0-9]+]] {
+// CHECK-DAG: define i32 @_Z3barv() #[[NEVERATTR:[0-9]+]] {
----------------
rnk wrote:
> Any reason to use -DAG on the decls? The IR should be in source order, with the attributes always at the end. The attribute sets need -DAG, of course.
Good question. I hadn't thought that through, I was just thinking that the attribute set -DAG needed to depend on variables captured from a -DAG earlier. Changed this now since it seems it's unnecessary. :)


Repository:
  rL LLVM

https://reviews.llvm.org/D31491