[PATCH] D29599: Clang Changes for alloc_align

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 30 12:51:15 PDT 2017


rjmccall added inline comments.


================
Comment at: lib/CodeGen/CGCall.cpp:4363
+    } else if (AllocAlignParam && TargetDecl->hasAttr<AllocAlignAttr>())
+      EmitAlignmentAssumption(Ret.getScalarVal(), AllocAlignParam);
   }
----------------
rjmccall wrote:
> Your old code was fine, you just needed to get the value with CallArgs[index].second.getScalarVal() instead of IRCallArgs[index].
Please add the test cases I suggested here.  You might have to make part of the test target-specific.


https://reviews.llvm.org/D29599





More information about the cfe-commits mailing list