[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

[Eric Fiselier via Phabricator via cfe-commits]

EricWF added inline comments.


================
Comment at: lib/Sema/CoroutineBuilder.h:53
+    assert(this->IsValid && "coroutine already invalid");
+    this->IsValid = makeReturnObject() && makeParamMoves();
+    if (this->IsValid && !IsPromiseDependentType)
----------------
GorNishanov wrote:
> makeReturnObject is built as $promise.get_return_object() should it be put into buildDependentStatements?
> 
I don't think so because the statement is required, so we can build it right away and transform it later. The "dependent" statements are ones built different depending on the results of name lookup.


https://reviews.llvm.org/D31487