[PATCH] D31491: [XRay][clang] Fix the -fxray-instruction-threshold flag processing

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 30 11:38:54 PDT 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: test/CodeGen/xray-instruction-threshold.cpp:11
+
+// CHECK-DAG: define i32 @_Z3foov() #[[THRESHOLD:[0-9]+]] {
+// CHECK-DAG: define i32 @_Z3barv() #[[NEVERATTR:[0-9]+]] {
----------------
Any reason to use -DAG on the decls? The IR should be in source order, with the attributes always at the end. The attribute sets need -DAG, of course.


https://reviews.llvm.org/D31491





More information about the cfe-commits mailing list