[PATCH] D31167: Use FPContractModeKind universally

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 29 13:44:29 PDT 2017


aaron.ballman added inline comments.


================
Comment at: include/clang/Basic/LangOptions.h:92
+  enum FPContractModeKind {
+    FPC_Off,        // Form fused FP ops only where result will not be affected.
+    FPC_On,         // Form fused FP ops according to FP_CONTRACT rules.
----------------
anemet wrote:
> aaron.ballman wrote:
> > I think you mean effected rather than affected.
> I think the verb is affect; effect is the noun.  Quick grep confirms:
> 
> /org/llvm$ git grep affected | wc -l
>      109
> /org/llvm$ git grep effected | wc -l
>        2
> 
I think I was thrown by "form" being the verb in that sentence, but you are correct. :-)


https://reviews.llvm.org/D31167





More information about the cfe-commits mailing list