[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

[Graham Hunter via Phabricator via cfe-commits]

huntergr added a comment.

In https://reviews.llvm.org/D31417#712008, @fpetrogalli wrote:

> Hi Graham,
>
> thank you for working on this. I understand that you are gonna take care of the CodeGen side of things for the new `-fopenmp-simd` option in a separate patch?


CodeGen for 'simd' pragmas works fine with this patch. 'declare simd' doesn't quite work yet, but yes, I was planning to do that in a separate patch.

> I am asking because I expect that the tests in `test/OpenMP/declare_simd_*` will give the same results when invoking clang with the new flag instead of `-fopenmp`.

So 'isAllowedClauseForDirective' needs to be updated; at present, it just bails out immediately if the directive kind passed in is OMPD_declare_simd. The clauses for a 'declare simd' are handled a little differently in ParseOpenMP.cpp, and I need to look into why.

I mainly wanted feedback on the approach at this point, since the patch is pretty small and changes won't be too cumbersome.


https://reviews.llvm.org/D31417