[PATCH] D29818: [libcxx] Threading support: Attempt to externalize system_clock::now() and steady_clock::now() implementations

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 27 19:29:47 PDT 2017


EricWF added a comment.

I really dislike that `__libcpp_clock_monotonic` and `__libcpp_clock_realtime` are never declared, and are expected to be magically defined by the external threading header.
This makes the configuration seem incorrect and unused.

Also the previous threading support changes were beneficial to libc++ because they cleaned up and centralized the threading interface, making it easier to port libc++ to different
threading environments. This change has no such benefit.

Why should libc++ upstream this ARM specific configuration need?


https://reviews.llvm.org/D29818





More information about the cfe-commits mailing list