[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 27 15:06:49 PDT 2017


gtbercea added inline comments.


================
Comment at: lib/Driver/ToolChains.cpp:4902
+          DeviceOffloadingKind == Action::OFK_Cuda) &&
+         "The offloading kind is not OpenMP or CUDA.");
 
----------------
jlebar wrote:
> Not sure this assertion message helps us much beyond what's already in the code.
Agreed. I've changed it to reflect that, currently, only OpenMP and CUDA offloading kinds are supported for this toolchain.


================
Comment at: lib/Driver/ToolChains.cpp:4914
+                           options::OPT_fno_cuda_approx_transcendentals,
+                           false))
+      CC1Args.push_back("-fcuda-approx-transcendentals");
----------------
jlebar wrote:
> Are these changes related to this patch?
> 
> I have no problem cleaning up whitespace errors like these, but would prefer for them to be split out separately if possible.
Reverted them, since they only concern line length.


================
Comment at: lib/Driver/ToolChains.cpp:4961
 
+  // If this is an OpenMP device we only need to append the gpu name.
+  if (DeviceOffloadKind == Action::OFK_OpenMP) {
----------------
jlebar wrote:
> jlebar wrote:
> > s/device/compilation/?
> An "otherwise" would probably be helpful in this comment.
Changed.


Repository:
  rL LLVM

https://reviews.llvm.org/D29647





More information about the cfe-commits mailing list