[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

[Leslie Zhai via Phabricator via cfe-commits]

xiangzhai added a comment.

Hi Raphael,

Thanks for your awesome job!

I have read about the slide <http://llvm.org/devmtg/2015-02/slides/sargsyan-code-clone.pdf> of "LLVM: built-in scalable code clone detection based on semantic analysis", and sent email to Shamil for asking "Is Code clone detection in LLVM compiler infrastructure available?" he replied me that the implementation (in LLVM IR layer?) is unavailable - close source. so I pay more attention to your implementation without LLVM IR, but I am really really really care about:

1. Performance. I use `scan-build -k -v -enable-checker alpha.clone.CloneChecker` to static analysis K3B <https://github.com/KDE/k3b>, it almost spend **one hour**! optimization plan?
2. False Positive. I use Coverity scan K3B <https://scan.coverity.com/projects/k3b> to compare with CloneDetector, there is **NO** false positive when detecting Copy-paste issue by setting **pattern** to ignore Qt Meta-Object Compiler <http://doc.qt.io/qt-5/moc.html> and other auto-generated source files. perhaps CloneChecker is able to learn this way to low false positive?

Thanks again for your great job!

Regards,
Leslie Zhai


https://reviews.llvm.org/D23418