[PATCH] D30760: Record command lines in objects built by clang, Clang part

[Eric Christopher via cfe-commits]

Sounds good to me.

On Sun, Mar 26, 2017, 9:40 AM David Blaikie <dblaikie at gmail.com> wrote:

> Yeah, I don't know/mind either way - I think there's a tidy simplicity to
> including exactly what the user wrote on the command line, so don't mind if
> it's not removed, but can see the argument to omit it. I'd probably leave
> it in for simplicity.
>
> On Fri, Mar 24, 2017 at 5:48 PM Eric Christopher via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
>
> Not sure, that's why I asked. Is it useful? Is it one of those things we
> want to remove since it'll be common among all of the TUs that want the
> text?
>
> On Fri, Mar 24, 2017 at 3:43 PM Zhizhou Yang via cfe-commits <
> cfe-commits at lists.llvm.org> wrote:
>
> Sure I can add some more tests here.
>
> For -grecord-gcc-switches itself, I think maybe we could keep it in
> recording, since it is also one of the options from command line?
>
> On Fri, Mar 24, 2017 at 2:54 PM, Eric Christopher via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
> echristo added inline comments.
>
>
> ================
> Comment at: test/Driver/debug-options.c:201-202
>  //
> +// GRECORD: "-dwarf-debug-flags"
> +// GRECORD: -### -c -grecord-gcc-switches
> +//
> ----------------
> This seems a little light on the testing, would you mind adding some more
> interesting lines here? (Also, -grecord-gcc-switches seems like an option
> we might want to ignore for this?)
>
>
> https://reviews.llvm.org/D30760
>
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170326/80b31fd1/attachment.html>