[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

Breno Rodrigues Guimaraes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 25 21:26:05 PDT 2017


brenoguim updated this revision to Diff 93062.
brenoguim added a comment.

- Removed the "#include <assert.h>" which caused problems in environments without that header
- Included a directory with -isystem to simulate system headers
- Added a "macro.h" header with definitions of types, functions and macros to simulate the assert.h header and others.
- Added checks for behavior in some situations

Some of the checks follow the comment "Not Ok. Should it be ok?"  to point the situations in which the check could be considered too strict for reporting such as violation. I would like to get feedback specially on them.


https://reviews.llvm.org/D31130

Files:
  clang-tidy/cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.cpp
  test/clang-tidy/Inputs/cppcoreguidelines-pro-bounds-array-to-pointer-decay/macro.h
  test/clang-tidy/cppcoreguidelines-pro-bounds-array-to-pointer-decay.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31130.93062.patch
Type: text/x-patch
Size: 7543 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170326/f4fb6e9b/attachment-0001.bin>


More information about the cfe-commits mailing list