[PATCH] D31252: [clang-tidy] add readability-compound-statement-size check.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 23 07:28:26 PDT 2017


alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.

Hi Roman,

Welcome to the community! As others noted, adding a separate check so similar functionally and implementation-wise to the existing one is not the best way to go here. A single check for all similar complexity limits would be a better solution. However, first I'd like to understand the specific use case you have for this check. Is there a recommendation of a certain style document to impose a complexity limit per-compound statement instead of a function? Should both limits be used? What would be the specific numbers and how should they interact with regard to nesting (e.g. should the warning be issued only on the innermost compound statement violating the rule or should it be issued on all levels)?


https://reviews.llvm.org/D31252





More information about the cfe-commits mailing list