[PATCH] D31210: [AMDGPU] Add new address space mapping

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added a comment.

In https://reviews.llvm.org/D31210#707842, @yaxunl wrote:

> In https://reviews.llvm.org/D31210#707832, @rampitec wrote:
>
> > I also do not exactly like names "old" and "new". This implies we are going to switch to "new" permanently and doing transition. That is not clear yet, however.
>
>
> How about we call the old address space mapping "Alloca Is Zero" (AIZ) address space mapping, whereas the new address space mapping "Generic Is Zero" (GIZ) address space mapping?
>
> I can change the variable names. Would you suggest to change the target triple environment name too? e.g. amdnas => amdgiz, amdnascl => amdgizcl?


I understand your indication. If we found the maintenance

In https://reviews.llvm.org/D31210#707855, @rampitec wrote:

> In https://reviews.llvm.org/D31210#707842, @yaxunl wrote:
>
> > In https://reviews.llvm.org/D31210#707832, @rampitec wrote:
> >
> > > I also do not exactly like names "old" and "new". This implies we are going to switch to "new" permanently and doing transition. That is not clear yet, however.
> >
> >
> > How about we call the old address space mapping "Alloca Is Zero" (AIZ) address space mapping, whereas the new address space mapping "Generic Is Zero" (GIZ) address space mapping?
> >
> > I can change the variable names. Would you suggest to change the target triple environment name too? e.g. amdnas => amdgiz, amdnascl => amdgizcl?
>
>
> I think "private is zero" is better than "alloca is zero". The latter may change. I also think it make sense for these to match evn name. What "nas" suffix stands for by the way?


nas means "New Address Space".


https://reviews.llvm.org/D31210