[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 22 03:24:56 PDT 2017


baloghadamsoftware added a comment.

Hi!

There is an option to disable the checking of widening casts. It is enabled by default. You can disable it any time. Or, if you find too much false positives, we can discuss about setting this option to disabled as default.

I am convinced that checking implicit widening casts are also necessary. We should probably change the error message in the implicit case from "misplaced" to "missing", and maybe also rename the checker itself. Separating it to two different checkers, which are almost copy of each other is huge code duplication.


Repository:
  rL LLVM

https://reviews.llvm.org/D31097





More information about the cfe-commits mailing list