[PATCH] D30845: Fix array sizes where address space is not yet known

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 21 08:38:12 PDT 2017


yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.





================
Comment at: lib/AST/ASTContext.cpp:2696
+  ArySize = ArySize.zextOrTrunc(
+      Target->getPreferredPointerWidth(getTargetAddressSpace(EltTy)));
 
----------------
Can we just use getMaxPointerWidth instead? If we cannot determine the pointer size, using max pointer size makes sense. Also can you add a ToDo comment about this. Ideally we could get a better fix later.


https://reviews.llvm.org/D30845





More information about the cfe-commits mailing list