[PATCH] D30009: Add support for '#pragma clang attribute'

[Eli Friedman via Phabricator via cfe-commits]

efriedma added a comment.

Looking over the most recent version, I'm happy with the general semantics of push with apply_only_to.  I'm not sure I see the point of apply_to: it doesn't allow the user to do anything that can't be done with apply_only_to.  Also, if the apply_to list for an attribute ever changes, it becomes impossible to write code which supports both versions of the compiler.


Repository:
  rL LLVM

https://reviews.llvm.org/D30009