[PATCH] D31128: Rename the safety module to be hicpp

Jonathan B Coe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 19 09:56:05 PDT 2017

jbcoe accepted this revision.
jbcoe added a comment.
This revision is now accepted and ready to land.


Great work on getting this module approved by PRQA Aaron.

Comment at: clang-tidy/hicpp/NoAssemblerCheck.cpp:46
+  diag(ASMLocation, "do not use inline assembler in safety-critical code");
aaron.ballman wrote:
> jbcoe wrote:
> > Should this message use text taken directly from the HICPP rules?
> The wording from HICPP rule is too wishy-washy to be used as a diagnostic, IMO. It just says it "should be avoided". I think the current wording is reasonable.
Should we remove 'in safety-critical code'? That's not HICPP's reason for banning it, they appeal to portability, and the module is no longer called 'safety'.

I'm happy with a shortened message or the message as is.


More information about the cfe-commits mailing list