[PATCH] D31126: Do not run tests for crash recovery if libstdc++ safe mode is enabled

Serge Pavlov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 19 06:49:32 PDT 2017

sepavloff created this revision.

If expensive checks are enabled, safe mode of libstdc++ is enabled too.
In this mode the library uses more complex data that allow additional
checks, for instance, a container may keep list of iterators that points
to it. If a code crashes it can leave these complex library objects in
inconsistent state. It occurs in a few tests that check error recovery
if compiler crashes. These test hang in expensive check mode, as the
library tries to synchronize access to the iterators pointing to some
container, but corresponding mutex remains locked after the crash.

This fix marks these tests as unsupported if clang is built with
libstdc++ safe mode enabled.



Index: test/lit.cfg
--- test/lit.cfg
+++ test/lit.cfg
@@ -437,15 +437,17 @@
 if platform.system() not in ['Windows']:
-# Returns set of available features, registered-target(s) and asserts.
+# Returns set of available features, registered-target(s), asserts and
+# compile definitions.
 def get_llvm_config_props():
     set_of_features = set()
     cmd = subprocess.Popen(
             os.path.join(llvm_tools_dir, 'llvm-config'),
+            '--cxxflags'
@@ -460,6 +462,11 @@
     for arch in cmd.stdout.readline().decode('ascii').split():
         set_of_features.add(arch.lower() + '-registered-target')
+    # 3rd line contains compile definitions, search it to define if
+    # libstdc++ safe mode is set.
+    if re.search(r'-D_GLIBCXX_DEBUG\b', cmd.stdout.readline().decode('ascii')):
+        set_of_features.add('libstdcxx-safe-mode')
     return set_of_features
Index: test/Index/crash-recovery.c
--- test/Index/crash-recovery.c
+++ test/Index/crash-recovery.c
@@ -4,5 +4,6 @@
 // RUN: env LIBCLANG_DISABLE_CRASH_RECOVERY=1 not --crash c-index-test -test-load-source all %s
 // REQUIRES: crash-recovery
+// UNSUPPORTED: libstdcxx-safe-mode
 #pragma clang __debug crash
Index: test/Index/crash-recovery-reparse.c
--- test/Index/crash-recovery-reparse.c
+++ test/Index/crash-recovery-reparse.c
@@ -7,5 +7,6 @@
 // CHECK-REPARSE-SOURCE-CRASH: Unable to reparse translation unit
 // REQUIRES: crash-recovery
+// UNSUPPORTED: libstdcxx-safe-mode
 #warning parsing original file
Index: test/Index/crash-recovery-modules.m
--- test/Index/crash-recovery-modules.m
+++ test/Index/crash-recovery-modules.m
@@ -4,14 +4,15 @@
 // Parse the file, such that building the module will cause Clang to crash.
 // RUN: not env CINDEXTEST_FAILONERROR=1 c-index-test -test-load-source all -fmodules -fmodules-cache-path=%t -Xclang -fdisable-module-hash -I %S/Inputs/Headers -DCRASH %s > /dev/null 2> %t.err
 // RUN: FileCheck < %t.err -check-prefix=CHECK-CRASH %s
-// CHECK-CRASH: crash-recovery-modules.m:16:9:{16:2-16:14}: fatal error: could not build module 'Crash'
+// CHECK-CRASH: crash-recovery-modules.m:17:9:{17:2-17:14}: fatal error: could not build module 'Crash'
 // Parse the file again, without crashing, to make sure that
 // subsequent parses do the right thing.
 // RUN: env CINDEXTEST_FAILONERROR=1 c-index-test -test-load-source all -fmodules -fmodules-cache-path=%t -Xclang -fdisable-module-hash -I %S/Inputs/Headers %s > /dev/null
 // REQUIRES: crash-recovery
 // REQUIRES: shell
+// UNSUPPORTED: libstdcxx-safe-mode
 @import Crash;
Index: test/Index/crash-recovery-code-complete.c
--- test/Index/crash-recovery-code-complete.c
+++ test/Index/crash-recovery-code-complete.c
@@ -10,5 +10,6 @@
 // FIXME: Please investigate abnormal path in MemoryBuffer.
 // REQUIRES: can-remove-opened-file
+// UNSUPPORTED: libstdcxx-safe-mode
 #warning parsing original file

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31126.92276.patch
Type: text/x-patch
Size: 3521 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170319/415d83b2/attachment.bin>

More information about the cfe-commits mailing list