[PATCH] D31114: Refactor `initTargetOptions` out of `EmitAssemblyHelper::CreateTargetMachine` and use it to initialize TargetOptions for ThinLTO Backends

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 18 10:26:13 PDT 2017

mehdi_amini added inline comments.

Comment at: clang/lib/CodeGen/BackendUtil.cpp:982
                               std::unique_ptr<raw_pwrite_stream> OS) {
+  EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M);
tejohnson wrote:
> Why did this move?
"History": it is useless now. I first refactored the initTargetOptions as a member on `EmitAssemblyHelper` rather than a static function.


More information about the cfe-commits mailing list