[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Mar 18 02:47:25 PDT 2017

alexfh added a comment.

In https://reviews.llvm.org/D31097#704626, @alexfh wrote:

> In https://reviews.llvm.org/D31097#704621, @xazax.hun wrote:
> > I wonder whether warning on implicit casts still makes sense for example in mission critical code. So maybe it is worth to have a configuration option with the default setting being less strict and chatty. What do you think?
> But it's not about "misplaced casts", it's about implicit conversions and -Wconversion diagnostic can take care of this.

Actually, the diagnostics about implicit casts here might be useful (but maybe in a separate check). I have to look again at https://reviews.llvm.org/D17987.



More information about the cfe-commits mailing list