[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

Daniel Marjamäki via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 17 08:34:25 PDT 2017

danielmarjamaki marked 2 inline comments as done.
danielmarjamaki added inline comments.

Comment at: lib/StaticAnalyzer/Core/CheckerHelpers.cpp:100
+                                                     BinaryOperatorKind BOK,
+                                                     const Expr *LExpr,
+                                                     const SVal RVal) {
a.sidorin wrote:
> I think we should rename these variables to LHSExpr, RHSVal, LHSVal. I don't like LVal/RVal because they may be associated with rvalue/lvalue types which is not what we want.
I agree. Good point.



More information about the cfe-commits mailing list