[PATCH] D30810: Preserve vec3 type.

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 16 03:38:16 PDT 2017

Anastasia added a comment.

In https://reviews.llvm.org/D30810#702443, @bruno wrote:

> > As a result, I think it would be good for clang to have both of features and I would like to stick to the option "-fpresereve-vec3' to change the behavior easily.
> The motivation doesn't seem solid to me, who else is going to benefit from this flag?

There are some off the main tree implementation that would benefit. But in the case of AMD GPU 3 loads/stores will be produced instead of 4. Sounds like a good optimization to me. As I said in my previous comment I think it should have been the default behavior from the beginning, but since different implementation landed first we can integrate this one now with an additional option.


More information about the cfe-commits mailing list