[PATCH] D30991: [Driver] Fix cross compiling with Visual Studio 2017

Zachary Turner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 15 17:54:36 PDT 2017

zturner added inline comments.

Comment at: lib/Driver/ToolChains/MSVC.cpp:517
+      }
+    }
+  SkipSettingEnvironment:
zturner wrote:
> I think you need to push 1 more null terminator onto the end here to terminate the block.
Actually if you use the `std::tie()` algorithm I proposed, then it will enter the body of the loop on the terminating null and push it back (as long as `MakeArgString` returns `nullptr` when its argument is empty, which I haven't checked)


More information about the cfe-commits mailing list