[PATCH] D30977: [CodeGen] Emit a CoreFoundation link guard when @available is used

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 15 11:23:18 PDT 2017


arphaman added inline comments.


================
Comment at: lib/CodeGen/CGObjC.cpp:3435
+      CheckFTy, "__clang_at_available_requires_core_foundation_framework"));
+  CFLinkCheckFunc->setLinkage(llvm::GlobalValue::LinkOnceAnyLinkage);
+  CodeGenFunction CGF(*this);
----------------
rjmccall wrote:
> Is this a public weak symbol?  Make it hidden, please.
> 
> Did you consider just adding "-framework CoreFoundation"  to the module link options?
I'm not familiar with module link options, I'll look into them.


Repository:
  rL LLVM

https://reviews.llvm.org/D30977





More information about the cfe-commits mailing list