[PATCH] D30854: [ASTMatchers] Add ObjC matchers for fundamental decls

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 15 09:10:28 PDT 2017

aaron.ballman added inline comments.

Comment at: unittests/ASTMatchers/ASTMatchersTest.h:64
     const std::string &Code, const T &AMatcher, bool ExpectMatch,
-    llvm::StringRef CompileArg,
+    std::vector<std::string> Args,
     const FileContentMappings &VirtualMappedFiles = FileContentMappings(),
I think this might be better as an `llvm::ArrayRef<llvm::StringRef>`.

Comment at: unittests/ASTMatchers/ASTMatchersTest.h:114
+  return matchesConditionally(
+    Code, AMatcher, ExpectMatch, std::vector<std::string>{CompileArg},
+    VirtualMappedFiles, Filename);
This could then use `makeArrayRef(CompileArg)`.


More information about the cfe-commits mailing list