[PATCH] D30931: [clang-tidy] added new identifier naming case type for ignoring case style

Beren Minor via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 14 09:52:23 PDT 2017

berenm added a comment.

In https://reviews.llvm.org/D30931#700690, @alexfh wrote:

> I understand your use case, but this patch makes the check's behavior more confusing: having both "any case" and "ignore case" with subtle differences in behavior seems very misleading. The problem seems to be coming from the usage of `CT_AnyCase` to denote uninitialized style. Should we just remove `NamingStyle::isSet` and use `llvm::Optional<NamingStyle>` instead of `NamingStyle` where appropriate?

I agree


More information about the cfe-commits mailing list