[PATCH] D30816: [OpenCL] Added implicit conversion rank for overloading functions with vector data type in OpenCL
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 14 06:50:35 PDT 2017
Anastasia added inline comments.
Comment at: test/SemaOpenCL/overload_addrspace_resolution.cl:1
-// RUN: %clang_cc1 -cl-std=CL2.0 -emit-llvm -o - -triple x86_64-unknown-unknown %s | FileCheck %s
+// RUN: %clang_cc1 -cl-std=CL2.0 -emit-llvm -o - -triple spir-unknown-unknown %s | FileCheck %s
> Egor, I think you forgot to move the test to CodeGenOpenCL directory.
Yes, I think we can also rename it to something more generic like overload.cl.
It would also be nice to start every separate testing section with a comment. Like here could be:
1. Checking address space resolution
2. Checking vector vs scalar resolution
More information about the cfe-commits