[PATCH] D30837: [libcxx] Support for shared_ptr<T()>

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 14 05:45:09 PDT 2017


erik.pilkington updated this revision to Diff 91660.
erik.pilkington added a comment.

In this new patch:

- We only select `allocator<int>` when _Yp is a function type, fixing the ABI break @EricWF pointed out.
- Only try to select a different allocator if we're using the `__shared_ptr_pointer` layout; `make_shared<void()>` doesn't make sense.
- Improve the testcase

Thanks for the feedback!
Erik


https://reviews.llvm.org/D30837

Files:
  include/memory
  test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/make_shared.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30837.91660.patch
Type: text/x-patch
Size: 5282 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170314/72df52dd/attachment.bin>


More information about the cfe-commits mailing list