[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

[Paulo Matos via Phabricator via cfe-commits]

pmatos added inline comments.


================
Comment at: lib/Sema/SemaExpr.cpp:4031
   // C99 6.5.3.4p4: the type (an unsigned integer type) is size_t.
+  if (isUnevaluatedContext() && ExprKind == UETT_SizeOf &&
+      TInfo->getType()->isVariablyModifiedType())
----------------
efriedma wrote:
> Is the isUnevaluatedContext() check here necessary?
Not really. Reran tests to ensure removing it doesn't break anything.


================
Comment at: test/SemaCXX/pr31042.cpp:1
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -emit-obj -disable-free %s
+
----------------
efriedma wrote:
> -emit-obj ?
Not needed. Left over from copying another test.


================
Comment at: test/SemaCXX/pr31042.cpp:3
+
+extern void abort (void);
+
----------------
efriedma wrote:
> Is this declaration necessary somehow?
Same. Not needed. Left over from copying another test.


https://reviews.llvm.org/D27800