[PATCH] D30915: Canonicalize the path provided by -fmodules-cache-path

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 13 15:28:12 PDT 2017


bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Frontend/CompilerInvocation.cpp:1434
+
+  // Canonicalize -fmodules-cache-path before storing it.
+  SmallString<128> P(Args.getLastArgValue(OPT_fmodules_cache_path));
----------------
I would suggest using `FileManager::makeAbsolutePath`, but at this point looks like we haven't set up a FileManager yet.


https://reviews.llvm.org/D30915





More information about the cfe-commits mailing list