[PATCH] D30743: enable -save-temps with -finclude-defult-header

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 13 10:50:51 PDT 2017


Anastasia added inline comments.


================
Comment at: lib/Driver/Tools.cpp:5288
   // parser.
-  Args.AddAllArgValues(CmdArgs, options::OPT_Xclang);
+  if (C.getDriver().isSaveTempsEnabled() &&
+      !isa<PreprocessJobAction>(JA)) {
----------------
It would be nice to add a comment around here explaining this case.


================
Comment at: lib/Driver/Tools.cpp:5290
+      !isa<PreprocessJobAction>(JA)) {
+    //Args.AddAllArgValues(CmdArgs, options::OPT_Xclang);
+    for (auto Arg : Args.filtered(options::OPT_Xclang)) {
----------------
Remove the commented code, please!


https://reviews.llvm.org/D30743





More information about the cfe-commits mailing list