[PATCH] D30816: [OpenCL] Added implicit conversion rank for overloading functions with vector data type in OpenCL

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 13 09:45:29 PDT 2017

Anastasia added inline comments.

Comment at: test/SemaOpenCL/overload-scalar-widening.cl:4
+typedef short short4 __attribute__((ext_vector_type(4)));
I am thinking could this be a CodeGen test instead and we could check that the right overload is selected based on mangled name?

I think in this case it would be good to unify with test/SemaOpenCL/overload_addrspace_resolution.cl which has similar purpose. Also I think CodeGenOpenCL would be a better place for it. :) 


More information about the cfe-commits mailing list