[PATCH] D30610: [clang-tidy] Added options to cppcoreguidelines-special-member-functions check

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 12 16:11:38 PDT 2017


alexfh added inline comments.


================
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:184
+  if (!MissingMembers.empty())
+    diag(ID.first, "class '%0' defines %1 but does not define %2")
+        << ID.second << join(DefinedMembers, " and ")
----------------
A note on usability: the diagnostic might be more useful, if it had a note pointing to each of the special members mentioned in %1. Just a thought without any relevance to this patch.


https://reviews.llvm.org/D30610





More information about the cfe-commits mailing list