[PATCH] D30766: Add support for attribute "enum_extensibility"

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 10 03:07:32 PST 2017


arphaman added inline comments.


================
Comment at: include/clang/Basic/Attr.td:887
+def EnumExtensibility : InheritableAttr {
+  let Spellings = [GNU<"enum_extensibility">];
+  let Subjects = SubjectList<[Enum]>;
----------------
We might as well have a C++11 spelling in the `clang` namespace as well.


================
Comment at: test/Sema/enum-attr.c:27
+
+enum __attribute__((enum_extensibility(arg1))) EnumInvalidArg { // expected-warning{{'enum_extensibility' attribute argument not supported: 'arg1'}}
+  G
----------------
Should this be an error instead?


https://reviews.llvm.org/D30766





More information about the cfe-commits mailing list