[PATCH] D30792: Use callback for internalizing linked symbols.

[Teresa Johnson via Phabricator via cfe-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with the format fix I pointed out.



================
Comment at: lib/CodeGen/CodeGenAction.cpp:186
+        } else {
+          Err = Linker::linkModules(*getModule(), std::move(LM.Module),
+                                    LM.LinkFlags);
----------------
tejohnson wrote:
> Similar question (to what I added to the LLVM patch just now) as to why this is needed given the default for that parameter.
As in the other patch, ignore my nonsense comment here.


Repository:
  rL LLVM

https://reviews.llvm.org/D30792