[PATCH] D30729: [ubsan] Skip range checks for width-limited values

Filipe Cabecinhas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 8 08:19:05 PST 2017


filcab added inline comments.


================
Comment at: test/CodeGenCXX/ubsan-bitfields.cpp:39
+  // CHECK-NOT: !nosanitize
+  return s->e3;
+}
----------------
Add checks/check-nots to make sure the thing you don't want isn't emitted, not just `!nosanitize`
The checks help document what you're trying to get in each test case.
Here I'd prefer to have a `CHECK-NOT: __ubsan_handle_load_invalid_value` than a check-not for `!nosanitize`, since checking for the handler call is more explicit.



https://reviews.llvm.org/D30729





More information about the cfe-commits mailing list