[PATCH] D26057: [coroutines] Add DependentCoawaitExpr and fix re-building CoroutineBodyStmt.

[Richard Smith via Phabricator via cfe-commits]

rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/clang/Sema/ScopeInfo.h:138-140
+  /// \brief Whether this function has already built, or tried to build, the
+  /// the initial and final coroutine suspend points.
+  bool NeedsCoroutineSuspends : 1;
----------------
Is the comment here correct? It seems a slightly odd match for the member name.


================
Comment at: lib/Sema/SemaCoroutine.cpp:33
 /// function type.
 static QualType lookupPromiseType(Sema &S, const FunctionProtoType *FnType,
+                                  SourceLocation KwLoc,
----------------
rsmith wrote:
> EricWF wrote:
> > The changes to this function are all unrelated cleanup/improvements.
> Just go ahead and commit these separately then.
Please commit these changes separately if they're cleanups unrelated to the main purpose of the patch.


================
Comment at: lib/Sema/TreeTransform.h:6974-6975
+
+  // FIXME(EricWF): Remove this
+  assert(isa<UnresolvedLookupExpr>(LookupResult.get()) && "Expected lookup expr");
+
----------------
Remove this :) (This is already checked by the `cast` below.)


https://reviews.llvm.org/D26057