[PATCH] D30214: [Driver] Search for libc++ headers in ResourceDir

Jonathan Roelofs via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 2 09:50:31 PST 2017


jroelofs added a comment.

In https://reviews.llvm.org/D30214#690375, @Hahnfeld wrote:

> In https://reviews.llvm.org/D30214#690010, @jroelofs wrote:
>
> > libc++ headers should not be installed in the resource dir.
>
>
> They are currently not by default. But with https://reviews.llvm.org/D30015 for runtime libraries, this may become a place for headers packaged with the compiler.


Note that I didn't say "are not", but rather "should not".

The only things that should live in the resource dir are things that are tied to the specific version of the compiler, i.e. sanitizer runtimes, builtins, and the few compiler-provided headers. Everything else should live in sysroots/SDKs, and the resource dir is not where those should live.


https://reviews.llvm.org/D30214





More information about the cfe-commits mailing list